(0.43) Fix PowerPC specific issues#18652
Merged
pshipton merged 1 commit intoeclipse-openj9:v0.43.0-releasefrom Dec 19, 2023
Merged
(0.43) Fix PowerPC specific issues#18652pshipton merged 1 commit intoeclipse-openj9:v0.43.0-releasefrom
pshipton merged 1 commit intoeclipse-openj9:v0.43.0-releasefrom
Conversation
-Replace do_{_if_(condition)_{_..._continute;_}_}while_{false}; with
for(;;)_{_if_(condition)_{...}_else{break;_}_} for an infinite loop
with a break logic to handle waiting concurrent gc finish during
continuation mounting. compiler might generate wrong logic for
do_while infinite loop.
-fix small hole during mounting synchronization with concurrent
scanning(for the case concurrent scanning start just before resetting
pendingmount flag-before reading the value of state for atomic update)
- new assertion check for catching issue earlier.
signed-off-by: hulin <linhu@ca.ibm.com>
pshipton
changed the title
pshipton
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Replace do_{if(condition){...continute;}}while{false}; with
for(;;){if(condition){...}else{break;}_} for an infinite loop
with a break logic to handle waiting concurrent gc finish during
continuation mounting. compiler might generate wrong logic for
do_while infinite loop.
-fix small hole during mounting synchronization with concurrent
scanning(for the case concurrent scanning start just before resetting
pendingmount flag-before reading the value of state for atomic update)
Port of #18637 for 0.43